Skip to content

Remove BlockBuilderStatus #27286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Remove BlockBuilderStatus #27286

wants to merge 5 commits into from

Conversation

@raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Nov 12, 2025

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Nov 12, 2025
@github-actions github-actions bot added docs iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector blackhole Blackhole connector elasticsearch Elasticsearch connector faker Faker connector kafka Kafka connector opensearch OpenSearch connector pinot Pinot connector postgresql PostgreSQL connector labels Nov 12, 2025
@raunaqmorarka
Remove unnecessary default constructor in PageBuilderStatus
c83a5dd
@raunaqmorarka
Remove unnecessary usages of PageBuilderStatus#createBlockBuilderStatus
f7cc55e
@raunaqmorarka
Remove usage of BlockBuilderStatus in PageBuilderStatus
df79bc1 
Use BlockBuilder#getSizeInBytes to calculate size of Page in PageBuilder.
Used a heuristic on observed size per position to avoid checking size
after addition of every position
@raunaqmorarka
Cap maximum PageBuilder entries at 64K
2e70cbe 
Current limit of Integer.MAX_VALUE is too high to be useful
@raunaqmorarka
Remove BlockBuilderStatus
bd2c8ad
@starburstdata-automation
Copy link

starburstdata-automation commented Nov 12, 2025 •
edited
Loading

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: failure

@starburstdata-automation
Copy link

starburstdata-automation commented Nov 12, 2025 •
edited
Loading

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_unpart.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

@starburstdata-automation
Copy link

starburstdata-automation commented Nov 12, 2025 •
edited
Loading

Started benchmark workflow for this PR with test type = iceberg/sf1000_parquet_part.

Building Trino finished with status: success
Benchmark finished with status: success
Comparing results to the static baseline values, follow above workflow link for more details/logs.
Status message: NO Regression found.
Benchmark Comparison to the closest run from Master: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

blackhole Blackhole connector cla-signed delta-lake Delta Lake connector docs elasticsearch Elasticsearch connector faker Faker connector hive Hive connector iceberg Iceberg connector kafka Kafka connector opensearch OpenSearch connector pinot Pinot connector postgresql PostgreSQL connector

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raunaqmorarka @starburstdata-automation